[PATCH] D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands

Ilia Diachkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 14:44:31 PST 2023


iliya-diyachkov added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp:165
+    for (auto &Op : I->operands()) {
+      if (isa<UndefValue>(Op) && Op->getType()->isAggregateType()) {
+        auto *AggrUndef = dyn_cast<UndefValue>(Op);
----------------
The indentation level could be reduced by
```
if (!condition)
  continue;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143107/new/

https://reviews.llvm.org/D143107



More information about the llvm-commits mailing list