[PATCH] D141712: [GVN] Improve PRE on load instructions

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 11:15:24 PST 2023


At this point, please revert the patch immediately.

There's been a probable bug reported.  There's been a failure reported.  
These are probably the same.  You should revert, investigate, and fix 
offline.

Philip

On 2/1/23 10:47, Guozhi Wei via Phabricator wrote:
> Carrot added a comment.
>
> @hans, do you have a reduced test case to demonstrate the problem?
>
> I exchanged emails with  @reames
>
>    A throwing call is a terminator, can we find a load below it ?
>    
>    On Mon, Jan 30, 2023 at 11:49 AM Philip Reames
>    
>    
>    <listmail at philipreames.com> wrote:
>    >
>    > You continue on any non-identical instruction.  That instruction can be
>    > a throwing call.
>    >
>    > Philip
>    >
>    > On 1/30/23 11:23, Carrot Wei wrote:
>    > > Hi Philip
>    > >
>    > > Do you have a reduced test case to show your problem?
>    > >
>    > > This patch tries to check exception throwing instructions in the
>    > > function findLoadToHoistIntoPred. What's your case that I missed?
>    > >
>    > > thanks
>    > > Guozhi Wei
>
>
> Repository:
>    rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>    https://reviews.llvm.org/D141712/new/
>
> https://reviews.llvm.org/D141712
>


More information about the llvm-commits mailing list