[PATCH] D140559: [InlineAdvisor] Restructure advisor plugin unittest cmake

[Jake Egan via Phabricator via llvm-commits]

Jake-Egan added inline comments.


================
Comment at: llvm/unittests/Analysis/CMakeLists.txt:69
 
-# The advisor plugin expects to not link against the Analysis, Support and Core 
-# libraries, but expects them to exist in the process loading the plugin. This 
-# doesn't work with DLLs on Windows (where a shared library can't have undefined
-# references), so just skip this testcase on Windows.
 if (NOT WIN32)
   # On AIX, enable run-time linking to allow symbols from the plugins shared
----------------
Is the WIN32 check not redundant when we check for AIX on the next line? Other than that you should be good to commit again, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140559/new/

https://reviews.llvm.org/D140559