[PATCH] D143073: [DebugInfo] Handle fixed-width DW_FORM_addrx variants in DWARFFormValue::getAsSectionedAddress()

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 10:00:49 PST 2023


dblaikie added a comment.

Could this be refactored to share some support/implementation with the dumping code so that the code is better tested?

(is this really untestable through LLVM tools? If you put an assert(false) in this if block, does it not fire on any LLVM tests?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143073/new/

https://reviews.llvm.org/D143073



More information about the llvm-commits mailing list