[PATCH] D141712: [GVN] Improve PRE on load instructions

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 09:30:19 PST 2023


hans added a subscriber: reames.
hans added a comment.

I'm not sure it explains our test failure, but @reames raised a concern on the llvm-commits email <https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20230130/1122056.html>:

  I believe this patch to be incorrect, and need reverted.
  
  The case I'm concerned about is that this patch appears to hoist a load 
  over instructions which may throw.  The load at the original location 
  may be dynamically dead because the exception path is always taken.  
  Moving said load into the executed path can introduce a new fault in the 
  program.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712



More information about the llvm-commits mailing list