[PATCH] D142482: [Codegen][ARM][AArch64] Support symmetric operations on complex numbers

Laine Taffin Altman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 09:01:21 PST 2023


pthariensflame added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-mixed-cases.ll:369-372
+; CHECK-NEXT:    movi v3.2d, #0000000000000000
+; CHECK-NEXT:    fcmla v3.4s, v0.4s, v1.4s, #0
+; CHECK-NEXT:    fcmla v3.4s, v0.4s, v1.4s, #90
+; CHECK-NEXT:    fadd v0.4s, v3.4s, v2.4s
----------------
Would it not be better to recognize the addend as part of the mla, thus saving an fadd?  Or is that out of scope for this patch, or wrong for some subtle reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142482/new/

https://reviews.llvm.org/D142482



More information about the llvm-commits mailing list