[llvm] 55eea6e - [AMDGPU][NFC] More precise predicates on GFX9 f16 insts

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 08:47:30 PST 2023


Author: Joe Nash
Date: 2023-02-01T11:47:04-05:00
New Revision: 55eea6eff96a93e8641abb667c8d1c41d4b28bd1

URL: https://github.com/llvm/llvm-project/commit/55eea6eff96a93e8641abb667c8d1c41d4b28bd1
DIFF: https://github.com/llvm/llvm-project/commit/55eea6eff96a93e8641abb667c8d1c41d4b28bd1.diff

LOG: [AMDGPU][NFC] More precise predicates on GFX9 f16 insts

Removes redundant Has16BitInsts and allows for future use
of OtherPredicates on V_DIV_FIXUP_F16_gfx9 and V_FMA_F16_gfx9

Reviewed By: foad

Differential Revision: https://reviews.llvm.org/D142990

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/VOP3Instructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/VOP3Instructions.td b/llvm/lib/Target/AMDGPU/VOP3Instructions.td
index 848d1ad1f6c7..e9ddbed09f09 100644
--- a/llvm/lib/Target/AMDGPU/VOP3Instructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP3Instructions.td
@@ -308,11 +308,11 @@ let FPDPRounding = 1 in {
     defm V_FMA_F16 : VOP3Inst <"v_fma_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, any_fma>;
   } // End Predicates = [Has16BitInsts, isGFX8Only]
 
-  let renamedInGFX9 = 1, Predicates = [Has16BitInsts, isGFX9Plus] in {
+  let renamedInGFX9 = 1, SubtargetPredicate = isGFX9Plus in {
     defm V_DIV_FIXUP_F16_gfx9 : VOP3Inst <"v_div_fixup_f16_gfx9",
                                           VOP3_Profile<VOP_F16_F16_F16_F16, VOP3_OPSEL>, AMDGPUdiv_fixup>;
     defm V_FMA_F16_gfx9 : VOP3Inst <"v_fma_f16_gfx9", VOP3_Profile<VOP_F16_F16_F16_F16, VOP3_OPSEL>, any_fma>;
-  } // End renamedInGFX9 = 1, Predicates = [Has16BitInsts, isGFX9Plus]
+  } // End renamedInGFX9 = 1, SubtargetPredicate = isGFX9Plus
 } // End FPDPRounding = 1
 
 let SubtargetPredicate = Has16BitInsts, isCommutable = 1 in {


        


More information about the llvm-commits mailing list