[PATCH] D94576: [LoopVectorize] Guard verifyFunction with EXPENSIVE_CHECKS macro

Tarique Islam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 06:56:58 PST 2023


tislam added a comment.

Thanks very much to all reviewers for your inputs. Unfortunately, I have moved to a different project. I am abandoning this review.

In case anyone wants to revisit the problem. the following observation might be helpful.

For my case, a given metadata appeared in multiple places. I noticed that the verification of a given metadata is done redundantly for each invocation to verify. The redundancy can be avoided by maintaining a verification status on the metadata. After the first verification, a metadata remains in verified state until the next update operation. Subsequent verifications can simply check and return the verfied status, in case the state is not stale.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94576/new/

https://reviews.llvm.org/D94576



More information about the llvm-commits mailing list