[PATCH] D142983: Add build for Windows on Arm in packaging script

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Could the refactorings (set_environment and do_build_libxml) be done in separate patches? That would make it easier to review.

Side question: has anyone tried the script on llvm-16.0.0-rc1 yet? I was meaning to do it but didn't find the cycles yet.



================
Comment at: llvm/utils/release/build_llvm_release.bat:144
   -DPython3_FIND_REGISTRY=NEVER ^
-  -DPACKAGE_VERSION=%package_version% ^
   -DLLDB_RELOCATABLE_PYTHON=1 ^
----------------
Why is this being dropped?


================
Comment at: llvm/utils/release/build_llvm_release.bat:302
+REM Note that we only enable compiler-rt so we can build the builtins, which are
+REM needed in the next stage when building flang.
+REM We need to build stage0 with clang-cl (for builtins).
----------------
We're building flang now?


================
Comment at: llvm/utils/release/build_llvm_release.bat:329
+  -DCPACK_SYSTEM_NAME=woa64 ^
+  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;flang;lld;lldb;compiler-rt;mlir"
+set cmake_flags=%all_cmake_flags:\=/%
----------------
..and mlir?

I wonder if we should try to keep LLVM_ENABLE_PROJECTS the same across targets, maybe there could be a flag to add flang to it if we need that.


================
Comment at: llvm/utils/release/build_llvm_release.bat:377
+cd libxmlbuild
+cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_C14N=OFF -DLIBXML2_WITH_CATALOG=OFF -DLIBXML2_WITH_DEBUG=OFF -DLIBXML2_WITH_DOCB=OFF -DLIBXML2_WITH_FTP=OFF -DLIBXML2_WITH_HTML=OFF -DLIBXML2_WITH_HTTP=OFF -DLIBXML2_WITH_ICONV=OFF -DLIBXML2_WITH_ICU=OFF -DLIBXML2_WITH_ISO8859X=OFF -DLIBXML2_WITH_LEGACY=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF -DLIBXML2_WITH_XPATH=OFF -DLIBXML2_WITH_XPTR=OFF -DLIBXML2_WITH_ZLIB=OFF ../../libxml2-v2.9.12 || exit /b 1
+ninja install || exit /b 1
----------------
This was probably my fault, but maybe add some newlines while here anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983