[PATCH] D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:1205
+      Instruction::Store, Type::getInt32Ty(Callee->getContext()),
+      DL.getPointerPrefAlignment(AMDGPUAS::PRIVATE_ADDRESS),
+      AMDGPUAS::PRIVATE_ADDRESS, TTI::TCK_SizeAndLatency);
----------------
Hardcoding 4 for the alignment would be fine (not that this argument will do anything)


================
Comment at: llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-ptr-argument.ll:2
+; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=inline -inline-cost-full=true -inline-threshold=0 -inline-instr-cost=5 -inline-call-penalty=0 -debug-only=inline < %s 2>&1 | FileCheck %s
+; REQUIRES: asserts
+
----------------
REQUIRES should be the first line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140242/new/

https://reviews.llvm.org/D140242