[PATCH] D142279: [cmake] Use LLVM_ENABLE_ASSERTIONS to enable assertions in libstdc++

Wed Feb 1 05:31:37 PST 2023

foad added a comment.

In D142279#4090165 <https://reviews.llvm.org/D142279#4090165>, @rovka wrote:

> EDIT: I asked on the flang slack instance, hopefully we'll get an opinion from someone more actively involved.

Thanks! The consensus on slack seemed to be that we should disable assertions (maybe just libstdc++ assertions?) in the runtime library. Does anyone know how to implement that in cmake? I experimented with remove_definitions(_GLIBCXX_ASSERTIONS) in flang/runtime/CMakeLists.txt but couldn't get it to work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142279/new/

https://reviews.llvm.org/D142279