[PATCH] D136234: [RFC][GISel] Add a way to ignore COPY instructions in InstructionSelector

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 05:07:51 PST 2023


Petar.Avramovic added a comment.

I like the GISelFlags, looks pretty lightweight.
Are you planning to add more flags?
About IgnoreCopies, it looks correct to me. Considering the possibility to break constant bus limit, patch synergies well with GISelPredicateCode that checks for it.
Can you add look through copies to Three Op Pats from VOP3 td file?
Upcoming regbankselect changes should be able to deal with copies but nevertheless I would like to see this one merged.
LGTM but I would wait for feedback from other reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136234/new/

https://reviews.llvm.org/D136234



More information about the llvm-commits mailing list