[llvm] 0ece205 - [SystemZ] Implement isGuaranteedNotToBeUndefOrPoisonForTargetNode().
Jonas Paulsson via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 04:28:52 PST 2023
Author: Jonas Paulsson
Date: 2023-02-01T13:28:18+01:00
New Revision: 0ece2050da3ecfdfcae86b2b165c767c2085a231
URL: https://github.com/llvm/llvm-project/commit/0ece2050da3ecfdfcae86b2b165c767c2085a231
DIFF: https://github.com/llvm/llvm-project/commit/0ece2050da3ecfdfcae86b2b165c767c2085a231.diff
LOG: [SystemZ] Implement isGuaranteedNotToBeUndefOrPoisonForTargetNode().
Returning true from this method for PCREL_WRAPPER and PCREL_OFFSET avoids
problems when a PCREL_OFFSET node ends up with a freeze operand, which is not
handled or expected by the backend.
Fixes #60107
Reviewed By: uweigand, RKSimon
Differential Revision: https://reviews.llvm.org/D142971
Added:
llvm/test/CodeGen/SystemZ/freeze.ll
Modified:
llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
llvm/lib/Target/SystemZ/SystemZISelLowering.h
Removed:
################################################################################
diff --git a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
index 7ad52422a3c46..1fb05fd32bb29 100644
--- a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
@@ -7443,6 +7443,18 @@ SystemZTargetLowering::ComputeNumSignBitsForTargetNode(
return 1;
}
+bool SystemZTargetLowering::
+isGuaranteedNotToBeUndefOrPoisonForTargetNode(SDValue Op,
+ const APInt &DemandedElts, const SelectionDAG &DAG,
+ bool PoisonOnly, unsigned Depth) const {
+ switch (Op->getOpcode()) {
+ case SystemZISD::PCREL_WRAPPER:
+ case SystemZISD::PCREL_OFFSET:
+ return true;
+ }
+ return false;
+}
+
unsigned
SystemZTargetLowering::getStackProbeSize(const MachineFunction &MF) const {
const TargetFrameLowering *TFI = Subtarget.getFrameLowering();
diff --git a/llvm/lib/Target/SystemZ/SystemZISelLowering.h b/llvm/lib/Target/SystemZ/SystemZISelLowering.h
index c5cc2cc3ae3a2..87d2eb1b5a54b 100644
--- a/llvm/lib/Target/SystemZ/SystemZISelLowering.h
+++ b/llvm/lib/Target/SystemZ/SystemZISelLowering.h
@@ -600,6 +600,10 @@ class SystemZTargetLowering : public TargetLowering {
const SelectionDAG &DAG,
unsigned Depth) const override;
+ bool isGuaranteedNotToBeUndefOrPoisonForTargetNode(
+ SDValue Op, const APInt &DemandedElts, const SelectionDAG &DAG,
+ bool PoisonOnly, unsigned Depth) const override;
+
ISD::NodeType getExtendForAtomicOps() const override {
return ISD::ANY_EXTEND;
}
diff --git a/llvm/test/CodeGen/SystemZ/freeze.ll b/llvm/test/CodeGen/SystemZ/freeze.ll
new file mode 100644
index 0000000000000..b833904655f25
--- /dev/null
+++ b/llvm/test/CodeGen/SystemZ/freeze.ll
@@ -0,0 +1,28 @@
+; RUN: llc -mtriple=s390x-linux-gnu -mcpu=zEC12 < %s | FileCheck %s
+;
+; Check that DAGCombiner doesn't cause a crash by eventually producing a
+; PCREL_OFFSET node with a freeze operand.
+
+ at a = dso_local global [6 x [6 x [3 x i8]]] zeroinitializer, align 2
+ at b = dso_local local_unnamed_addr global i32 0, align 4
+
+define void @fun(i8 noundef zeroext %g) {
+; CHECK-LABEL: fun
+entry:
+ %agg.tmp.ensured.sroa.0 = alloca i8, align 2
+ %conv = zext i8 %g to i64
+ %0 = inttoptr i64 %conv to ptr
+ %.fr = freeze ptr getelementptr inbounds ([6 x [6 x [3 x i8]]], ptr @a, i64 0, i64 1, i64 2, i64 1)
+ %cmp = icmp eq ptr %.fr, %0
+ %1 = load i8, ptr getelementptr inbounds ([6 x [6 x [3 x i8]]], ptr @a, i64 0, i64 5, i64 4, i64 2), align 2
+ %conv2 = zext i8 %1 to i32
+ br i1 %cmp, label %for.cond.us, label %for.cond
+
+for.cond.us: ; preds = %entry, %for.cond.us
+ store i32 %conv2, ptr @b, align 4
+ ret void
+
+for.cond: ; preds = %entry, %for.cond
+ store i32 0, ptr @b, align 4
+ ret void
+}
More information about the llvm-commits
mailing list