[PATCH] D142998: [SVE][codegen] Add test case for a fused multiply-add (NFC)

Wed Feb 1 03:35:07 PST 2023

sushgokh added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/sve-multiply-add-accumulate.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-unknown-linux-gnu -mattr=+sve < %s | FileCheck %s
----------------
david-arm wrote:
> Perhaps it's better to just add these tests to the existing sve-int-mad-pred.ll file?
Just thought better to have seperate file because sve-int-mad-pred.ll  only has intrinsics. If you suggest, will add all the tests to that file

================
Comment at: llvm/test/CodeGen/AArch64/sve-multiply-add-accumulate.ll:165
+; negative integer splat as one of the addend
+define <vscale x 8 x i16> @muladd_generic_test4(<vscale x 8 x i16> %a, <vscale x 8 x i16> %b)
+; CHECK-LABEL: muladd_generic_test4:
----------------
david-arm wrote:
> I'm not sure what this is doing that is different to `@muladd_i8_negativeAddend`? Are you just trying to test a case where the immediate is too big to fit into the 'add'?
In this test, unlike the other tests, immediate is realised using 2 register moves.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142998/new/

https://reviews.llvm.org/D142998