[PATCH] D143056: [RFC][IR] llvm.minimum/maximum NaN propagation.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 03:30:53 PST 2023


samparker added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14844
 """"""""""
-If either operand is a NaN, returns NaN. Otherwise returns the greater
-of the two arguments. -0.0 is considered to be less than +0.0 for this
-intrinsic. Note that these are the semantics specified in the draft of
-IEEE 754-2018.
+If one operand is a NaN, return that NaN. If both operands are NaNs, return
+either one of them. Otherwise returns the greater of the two arguments.
----------------
arsenm wrote:
> Are the payload bits really guaranteed?
That's the purpose of this RFC, no? The proposal would allow minimum/maximum to behave as fcmp + select and, as the select is bitwise, the payload should be identical. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143056/new/

https://reviews.llvm.org/D143056



More information about the llvm-commits mailing list