[PATCH] D142656: [SVE][codegen] Add pattern for SVE multiply-add accumulate

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

And for completeness, summarising previous comments, these are my other 2 concerns.

We need an alternative for:

  for(SDNode* use: Op1->uses())

This is not doing what we want. So my question here is why we need it, why a hasOneUse check won't suffice? What is the motivation test case? If we know that, perhaps we can have a think about this.

Second, this could be related to the above, but I remember from some tests that we are missing a few opportunities. Why is that? What would be needed to recognises these cases? Reason I am asking is to see if this is the right place to do this thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142656/new/

https://reviews.llvm.org/D142656