[PATCH] D143049: Use ArrayRef instead of raw pointers. NFC

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 01:03:43 PST 2023


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LG.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14950-14951
+ArrayRef<MCPhysReg> AArch64TargetLowering::getRoundingControlRegisters() const {
+  static const MCPhysReg RCRegs[] = {AArch64::FPCR};
   return RCRegs;
 }
----------------
Maybe `return {AArch64::FPCR};`?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3103
   // tests at the moment, which is not what we expected.
-  static const MCPhysReg RCRegs[] = { X86::MXCSR, 0 };
+  static const MCPhysReg RCRegs[] = {X86::MXCSR};
   return RCRegs;
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143049/new/

https://reviews.llvm.org/D143049



More information about the llvm-commits mailing list