[PATCH] D136912: [AArch64] precommit tests for D136623, NFC

Tue Jan 31 23:40:42 PST 2023

Allen added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/add4.ll:151
+; CHECK-NEXT:    [[A0:%.*]] = add i16 [[X:%.*]], -1
+; CHECK-NEXT:    [[M:%.*]] = shl i16 [[X]], 2
+; CHECK-NEXT:    [[A1:%.*]] = add i16 [[M]], [[A0]]
----------------
spatel wrote:
> As I wrote previously, this is not a good test of "x*4". It is a test of "x<<2" as shown by the CHECKs.
> Unit-tests should avoid other transforms, so they do not break or become meaningless from independent changes. 
> 
> Hopefully, other reviewers can explain this better. Since I can't seem to get this point across, I'll resign.
Sorry for missing addressing

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136912/new/

https://reviews.llvm.org/D136912