[PATCH] D142786: [InstCombine] Improve transforms for (icmp uPred X * Z, Y * Z) -> (icmp uPred X, Y)

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 16:00:43 PST 2023


goldstein.w.n added a comment.

In D142786#4093976 <https://reviews.llvm.org/D142786#4093976>, @spatel wrote:

> If the 3 improvements are independent, it would be better to make this into 3 small patches. That makes it easier to review and reduces risk.

I split the constant case too D143026 <https://reviews.llvm.org/D143026>.

My preference is too keep the rest of this together, its three cases, but those three cases where what was covered in the previous
code block and I couldn't find a clean way to only partially insert this patch w.o causing regressions from missing cases b.c the old
code was removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142786/new/

https://reviews.llvm.org/D142786



More information about the llvm-commits mailing list