[PATCH] D143020: [lld][WebAssembly] Apply relocations to TLS data

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/Symbols.cpp:312
   if (isTLS() && config->sharedMemory)
-    return getOutputSegmentOffset() + value;
+    return getOutputSegmentOffset();
   if (segment)
----------------
This is perhaps a concerning change.  The original line here was added without any test changes in: https://reviews.llvm.org/D112831.  Its seems to lack test coverage although the new test I've add here adds coverage.

I also ran the entire emscripten test suite with this change to ensure this change doesn't break anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143020/new/

https://reviews.llvm.org/D143020