[PATCH] D143016: [InstCombine] Promote expression tree with @llvm.vscale when zero-extending result.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 14:12:48 PST 2023


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/vscale.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes='instcombine' -S < %s | FileCheck %s
----------------
goldstein.w.n wrote:
> Can the tests the split into a separate patch so we can see the diff?
Does the test need to be AArch64 specific? IIUC this is a target-independent fold of @llvm.vscale, so it might  be better to have a generic test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143016/new/

https://reviews.llvm.org/D143016



More information about the llvm-commits mailing list