[PATCH] D124787: [NVPTX] Implement NVPTX AliasAnalysis

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAliasAnalysis.cpp:72
+                                 const MemoryLocation &Loc2, AAQueryInfo &AAQI,
+                                 const Instruction *CtxI) {
+  unsigned AS1 = Loc1.Ptr->getType()->getPointerAddressSpace();
----------------
asavonic wrote:
> tra wrote:
> > `CtxI` does not seem to be used. Do we need it?
> It is a new parameter from D136512. We do not currently use it, so I guess it is better to drop it to avoid warnings.
So, the intent is to match  the signature of `AAResultBase::alias()`? 
OK. I was thinking of getting rid of the argument altogether, but it looks like it's needed, after all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124787/new/

https://reviews.llvm.org/D124787