[PATCH] D142656: [SVE][codegen] Add pattern for SVE multiply-add accumulate

Tue Jan 31 12:18:18 PST 2023

sushgokh added a comment.

In D142656#4093946 <https://reviews.llvm.org/D142656#4093946>, @SjoerdMeijer wrote:

> and one more request, which I forgot to add earlier:
>
>> The patch aims at:
>>
>> 1. Try to generate multiply-accumulate instructions post-isel at more places
>> 2. Improving the current functionality of 'mad' instruction(which only kicks in if intrinsic is used)
>> 3. with 'mla' instruction, it has been observed at multiple places that it generates extra register moves especially if the added is constant. This patch aims to improve this.
>
> We should be doing one thing at a time. This patch is about 'mad' instruction selection, so please remove anything related to 3. in this patch, if possible, and prepare a follow up patch for that.

Agreed. Will  go with constant splats as addend  first. Will update the description of the patch here

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142656/new/

https://reviews.llvm.org/D142656