[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 11:36:56 PST 2023


wolfgangp added a comment.

In D140123#4094007 <https://reviews.llvm.org/D140123#4094007>, @probinson wrote:

> I don't know if this can happen, but what about an LTO scenario with different values for the module flag? I seem to recall module flags needing to provide a merge policy?  I might be remembering something else though.
> If the result is "fail the compilation" that seems fine.

Yeah, the module flag is created with behavior "Error" (the first parameter in addModuleFlag), so any conflicting values would cause a module link time error (at LTO time).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140123/new/

https://reviews.llvm.org/D140123



More information about the llvm-commits mailing list