[PATCH] D142974: [AArch64] Avoid using JumpTableEntryInfo when lowering jump tables when it is not initialized

Tue Jan 31 11:25:25 PST 2023

efriedma added a comment.

I'd prefer to make the MIR-parsed codepath as similar as possible to the normal codepath.  There are two ways you could do that:

1. Teach yaml::AArch64FunctionInfo to dump/parse JumpTableEntryInfo.
2. Drop the calls to setJumpTableEntryInfo from isel... which I guess implies we can't model the effect of AArch64CompressJumpTables, but otherwise does the right thing.

================
Comment at: llvm/test/CodeGen/AArch64/arm64-jumptable.ll:6
+; RUN: llc -mtriple=aarch64 -stop-after=unpack-mi-bundles -o %t.mir %s
+; RUN: llc %t.mir -mtriple=aarch64 -start-after=unpack-mi-bundles -o - | FileCheck %s --check-prefix=CHECK-MIR
+
----------------
I don't think you need a dedicated testcase for this, if you're planning to use this functionality in the near future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142974/new/

https://reviews.llvm.org/D142974