[PATCH] D142997: [RISCV] Move the even register check for rv32zdinx later in the matching process.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 10:39:19 PST 2023


craig.topper created this revision.
craig.topper added reviewers: asb, luismarques, reames, jrtc27.
Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

And remove the IsRV64 checks for isGPRAsFPR and isGPRPF64AsFPR.

Overall I think this results in a better diagnostic experience. We
now do a better job of matching Zdinx instructions even if the registers
aren't correct and report an error for missing features like RV64.

Unfortunately, this makes it difficult to recover the error location
for the invalid odd register when we do report it. But to make up
for it, I gave a more specific error message.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142997

Files:
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  llvm/test/MC/RISCV/rv32zdinx-invalid.s
  llvm/test/MC/RISCV/rv32zfinx-invalid.s
  llvm/test/MC/RISCV/rv64zdinx-valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142997.493670.patch
Type: text/x-patch
Size: 8365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230131/e602ef72/attachment.bin>


More information about the llvm-commits mailing list