[PATCH] D142323: [Kaleidoscope] Update code snippets in text to match full code listings

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 10:07:53 PST 2023


xgupta added a comment.

In D142323#4093787 <https://reviews.llvm.org/D142323#4093787>, @0xdc03 wrote:

> Okay, I have fixed the code and I think the patch is ready now. It turns out you have to specify the number of commits to push to the patch, arc doesn't pick up on it automatically. Also, in my case it didn't pick up on the fact that I already had a patch (or is it revision?) made, so I had to use the command `arc diff HEAD~~ --update D142323` and everything seems fine.

I use `arc diff` to upload and update the patch every time (I heard people saying arcanist is smart) and `arc patch D142323` to review the author's patch.

> Thank you so much for reviewing my first patch :>

Congratulations! Thank you very much for contributing. Hope a lot more patches will come soon :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142323/new/

https://reviews.llvm.org/D142323



More information about the llvm-commits mailing list