[PATCH] D142656: [SVE][codegen] Add pattern for SVE multiply-add accumulate

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 08:24:28 PST 2023


SjoerdMeijer added a comment.

Ok, I misunderstood a few things, but see comment inlined.



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:350
+  unsigned nUses = 0;
+  for(SDNode* use: Op1->uses())
+  {
----------------
This doesn't do what you think it does, I think.
This returns the uses of this node in the graph, it doesn't return the def-uses.

So the question is for which test-case you need this and why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142656/new/

https://reviews.llvm.org/D142656



More information about the llvm-commits mailing list