[PATCH] D142983: Add build for Windows on Arm in packaging script

[Muhammad Omair Javaid via Phabricator via llvm-commits]

omjavaid added a comment.

This looks good to me after fixing nits mentioned inline.



================
Comment at: llvm/utils/release/build_llvm_release.bat:323
+  %cmake_flags% ^
+  -DCMAKE_C_COMPILER=%stage0_bin_dir%/clang-cl.exe ^
+  -DCMAKE_CXX_COMPILER=%stage0_bin_dir%/clang-cl.exe ^
----------------
These flags are common to all stage1 builds and can be added to variable that be included to all stage1 builds.


================
Comment at: llvm/utils/release/build_llvm_release.bat:332
+  -DCOMPILER_RT_BUILD_SANITIZERS=OFF ^
+  -DLLDB_ENABLE_PYTHON=ON ^
+  -DLLDB_RELOCATABLE_PYTHON=ON ^
----------------
These LLDB python related flags should be common for all Stage1 builds too. Should be added to a common variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983