[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

Aside from a nit about comments, I don't have any further concerns. LGTM!



================
Comment at: clang/include/clang/Basic/WebAssemblyReferenceTypes.def:16
+//
+//  - Name is the name of the builtin type.  MangledName is the mangled name.
+//
----------------
pmatos wrote:
> aaron.ballman wrote:
> > aaron.ballman wrote:
> > > What kind of mangling is this name? Itanium? Microsoft? Something else?
> > Still wondering about this.
> This is just a generic name to base the actual mangling on tbh.
Can you clarify the comment then? I'd expect `MangledName` to be an actual mangling, otherwise, and that's why I was wondering "which mangling?".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122215/new/

https://reviews.llvm.org/D122215