[PATCH] D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

As you've reverted this patch and folded in the changes from D142883 <https://reviews.llvm.org/D142883>, you might as well mark D142883 <https://reviews.llvm.org/D142883> as abandoned.



================
Comment at: llvm/lib/Object/Archive.cpp:141
+      *Err = malformedError(
+          "Remaining buffer is unable to contain next archive member");
+    return;
----------------
This message isn't covered by any testing it seems?


================
Comment at: llvm/lib/Object/Archive.cpp:1185
+  if (BufferSize < sizeof(FixLenHdr)) {
+    Err = malformedError("malformed AIX big archive: Incomplete fixed length "
+                         "header, the archive is only" +
----------------
I don't see a test case that checks this error message. Please add/extend one to cover it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138986/new/

https://reviews.llvm.org/D138986