[PATCH] D142456: [AArch64][CostModel]: Add costs for zero/sign extend.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed



================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-ext.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -passes="print<cost-model>" 2>&1 -disable-output -mtriple aarch64-linux-gnu -mattr=+sve -S -o - < %s | FileCheck %s
----------------
We have quite a few different files for the different kinds of extends, it might be nice to move them all to a single `sve-cast.ll` at some point (in a separate patch), similar to what was done for `cast.ll`


================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-ext.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -passes="print<cost-model>" 2>&1 -disable-output -mtriple aarch64-linux-gnu -mattr=+sve -S -o - < %s | FileCheck %s
+
----------------
I don't think this is needed as  there is  no IR output (because of the `-disable-output`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142456/new/

https://reviews.llvm.org/D142456