[PATCH] D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Support/LLVMDriver.h:18-24
+  const char *PrependArg;
+  // PrependArg will be added unconditionally by the llvm-driver, but
+  // NeedsPrependArg will be false if Path is adequate to reinvoke the tool.
+  // This is useful if realpath is ever called on Path, in which case it will
+  // point to the llvm-driver executable, where PrependArg will be needed to
+  // invoke the correct tool.
+  bool NeedsPrependArg;
----------------
This is just a suggestion so feel free to ignore this, but I was thinking about these names a bit more and I think that `Name` and `NeedsName` might be more self-descriptive?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137800/new/

https://reviews.llvm.org/D137800