[PATCH] D142323: [Kaleidoscope] Update code snippets in text to match full code listings

Dhruv Chawla via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 22:19:06 PST 2023


0xdc03 added a comment.

@xgupta I have updated the comment in the code listing to match the code that creates the function. I think it is better to keep the `ExitOnError` variable as I was quite confused as to what `ExitOnErr` was when reading the tutorial and I only realized it once I scrolled to the end and found the declaration. If this seems correct to you, can you land this patch for me as I do not have commit access? Please use "Dhruv Chawla <dhruv263.dc at gmail.com>" to commit the change.

Thanks!

PS: I am a little concerned if I updated my revision correctly: I used `arc diff --update` to commit my second change, and I am not sure if that is correct as phabricator is only showing the diff against the second commit...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142323/new/

https://reviews.llvm.org/D142323



More information about the llvm-commits mailing list