[PATCH] D142879: [RISCV] Emit relocation for uleb128

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:283
+
+  int64_t IntValue;
+  if (!Value->evaluateAsAbsolute(IntValue, getAssemblerPtr())) {
----------------
encodeULEB128 takes a uint64_t


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:287
+    // by linker later.
+    IntValue = -1ll;
+  }
----------------
Why not just use encodeULEB128's PadTo and encode 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142879/new/

https://reviews.llvm.org/D142879