[PATCH] D142170: [AVR][NFC] Refactor 'AVRAsmPrinter::PrintAsmOperand'

Chenbing.Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 18:05:56 PST 2023


Chenbing.Zheng added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRAsmPrinter.cpp:111
+    // Unknown extra code.
+    if (ExtraCode[1] != 0 || ExtraCode[0] < 'A' || ExtraCode[0] > 'Z')
+      return true;
----------------
It seems that //ExtraCode[0] < 'A' || ExtraCode[0] > 'Z'// will return false according to the original logic ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142170/new/

https://reviews.llvm.org/D142170



More information about the llvm-commits mailing list