[PATCH] D137139: [DWARF] Fix handling of .debug_aranges with -g1

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In D137139#4091685 <https://reviews.llvm.org/D137139#4091685>, @dblaikie wrote:

> In D137139#4091500 <https://reviews.llvm.org/D137139#4091500>, @clayborg wrote:
>
>> In D137139#4091496 <https://reviews.llvm.org/D137139#4091496>, @dblaikie wrote:
>>
>>> In D137139#4091399 <https://reviews.llvm.org/D137139#4091399>, @clayborg wrote:
>>>
>>>> In D137139#4091380 <https://reviews.llvm.org/D137139#4091380>, @dblaikie wrote:
>>>>
>>>>> In D137139#4090779 <https://reviews.llvm.org/D137139#4090779>, @ayermolo wrote:
>>>>>
>>>>>> To me it sounds it's easier to just fix it in llvm, no?
>>>>>
>>>>> Though that doesn't address the concern @clayborg that lldb will still misbehave on existing compiled code?
>>>>
>>>> Which is ok, this is to fix the compiler. I can make separate LLDB changes to address the reality of the situation.
>>>
>>> What sort of change to LLDB are you thinking of?
>>
>> using DW_AT_ranges instead of .debug_aranges if they are available.
>
> So then LLDB wouldn't use this .debug_aranges data this patch fixes, right? So could we remove this .debug_aranges data instead?

Older LLDB versions which are out in the wild and will exist until the end of time will use the .debug_aranges. So I would vote to fix the compiler and do it with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137139/new/

https://reviews.llvm.org/D137139