[PATCH] D142547: [LLD] cleans up context and symbol table to allow multiple invocations to lld::elf::linker()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 16:45:03 PST 2023


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

This is not a proper fix. After D108850 <https://reviews.llvm.org/D108850> the user of `lld::elf::link` now needs to manually invoke `CommonLinkerContext::destroy();` (see `lld/tools/lld/lld.cpp`).
I agree that requiring another function call is not that ergonomic but I think we need a better solution instead of landing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142547/new/

https://reviews.llvm.org/D142547



More information about the llvm-commits mailing list