[PATCH] D142021: AMDGPU/GlobalISel: Add stub custom regbankselect pass

Mon Jan 30 12:18:43 PST 2023

arsenm closed this revision.
arsenm marked an inline comment as done.
arsenm added a comment.

e9c49901a43f5b16c3df416460b7e4dbdd24ce03 <https://reviews.llvm.org/rGe9c49901a43f5b16c3df416460b7e4dbdd24ce03>

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegBankSelect.cpp:14
+
+#define DEBUG_TYPE "regbankselect"
+
----------------
rovka wrote:
> arsenm wrote:
> > rovka wrote:
> > > Nit: This diverges from AMDGPUInstructionSelector and Legalizer, which both define the DEBUG_TYPE as "amdgpu-blah" directly.
> > Those should probably use the generic name. Different debug types for the same pass are counterproductive
> Be that as it may, I'd prefer using the same string for -stop-before/after and -debug-only. As it is now we'd have to use "amdgpu-regbankselect" to run the pass and just "regbankselect" to get the debug logs.
If I change this to amdgpu-regbankselect, -debug-only=amdgpu-regbankselect will print a fraction of the debugging information. The real debug information is in the base classes and you can't stack -debug-onlys

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142021/new/

https://reviews.llvm.org/D142021