[llvm] 76d7a6a - Revert "[LTO] Demangle the function name in DiagnosticInfoDontCall message"

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 11:17:10 PST 2023


Author: Arthur Eubanks
Date: 2023-01-30T11:16:58-08:00
New Revision: 76d7a6ad13be601bd93e7c5fa9988326b4e05b6e

URL: https://github.com/llvm/llvm-project/commit/76d7a6ad13be601bd93e7c5fa9988326b4e05b6e
DIFF: https://github.com/llvm/llvm-project/commit/76d7a6ad13be601bd93e7c5fa9988326b4e05b6e.diff

LOG: Revert "[LTO] Demangle the function name in DiagnosticInfoDontCall message"

This reverts commit cb05c2ffc79eefe74c569263e27fcb5fad167ba3.

Breaks https://lab.llvm.org/buildbot/#/builders/121/builds/27524/steps/4/logs/stdio

Added: 
    

Modified: 
    llvm/lib/IR/DiagnosticInfo.cpp
    llvm/test/CodeGen/X86/attr-dontcall.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/DiagnosticInfo.cpp b/llvm/lib/IR/DiagnosticInfo.cpp
index a19d9d607f4b6..fb238e2aac59c 100644
--- a/llvm/lib/IR/DiagnosticInfo.cpp
+++ b/llvm/lib/IR/DiagnosticInfo.cpp
@@ -15,7 +15,6 @@
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/Twine.h"
 #include "llvm/ADT/iterator_range.h"
-#include "llvm/Demangle/Demangle.h"
 #include "llvm/IR/BasicBlock.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/DebugInfoMetadata.h"
@@ -441,8 +440,7 @@ void llvm::diagnoseDontCall(const CallInst &CI) {
 }
 
 void DiagnosticInfoDontCall::print(DiagnosticPrinter &DP) const {
-  DP << "call to " << demangle(getFunctionName().str())
-     << " marked \"dontcall-";
+  DP << "call to " << getFunctionName() << " marked \"dontcall-";
   if (getSeverity() == DiagnosticSeverity::DS_Error)
     DP << "error\"";
   else

diff  --git a/llvm/test/CodeGen/X86/attr-dontcall.ll b/llvm/test/CodeGen/X86/attr-dontcall.ll
index ea3ad180d515e..8b518aee6dce2 100644
--- a/llvm/test/CodeGen/X86/attr-dontcall.ll
+++ b/llvm/test/CodeGen/X86/attr-dontcall.ll
@@ -27,34 +27,7 @@ define void @bar4() {
   ret void
 }
 
-declare i32 @_Z3fooi(i32) "dontcall-error"
-define void @demangle1() {
-  call i32 @_Z3fooi (i32 0)
-  ret void
-}
-declare float @_Z3barf(float) "dontcall-error"
-define void @demangle2() {
-  call float @_Z3barf(float 0.0)
-  ret void
-}
-
-declare i32 @_RNvC1a3baz() "dontcall-error"
-define void @demangle3() {
-  call i32 @_RNvC1a3baz()
-  ret void
-}
-
-
-declare i32 @_Z3fooILi79EEbU7_ExtIntIXT_EEi(i32) "dontcall-error"
-define void @demangle4() {
-  call i32 @_Z3fooILi79EEbU7_ExtIntIXT_EEi(i32 0)
-  ret void
-}
 ; CHECK: error: call to foo marked "dontcall-error": e
 ; CHECK: warning: call to foo2 marked "dontcall-warn": w
 ; CHECK: warning: call to foo3 marked "dontcall-warn"{{$}}
 ; CHECK: warning: call to foo4 marked "dontcall-warn": cast
-; CHECK: error: call to foo(int) marked "dontcall-error"
-; CHECK: error: call to bar(float) marked "dontcall-error"
-; CHECK: error: call to a::baz marked "dontcall-error"
-; CHECK: error: call to bool foo<79>(int _ExtInt<79>) marked "dontcall-error"
\ No newline at end of file


        


More information about the llvm-commits mailing list