[PATCH] D142847: [InstCombine] reduce icmp_eq0-of-and-of-select-of-constants

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:1898
+  // TODO: Extend to handle a non-zero compare constant.
+  if (Pred == CmpInst::ICMP_EQ && C.isZero()) {
+    Value *A, *B;
----------------
goldstein.w.n wrote:
> Is the plan to handle the `ICMP_NE` case in another patch?
> Is the plan to handle the `ICMP_NE` case in another patch?

Ignore, see TODO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142847/new/

https://reviews.llvm.org/D142847