[PATCH] D142844: [LTO] Demangle the function name in DiagnosticInfoDontCall message

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 09:22:24 PST 2023


nickdesaulniers requested changes to this revision.
nickdesaulniers added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/IR/DiagnosticInfo.cpp:444
 void DiagnosticInfoDontCall::print(DiagnosticPrinter &DP) const {
-  DP << "call to " << getFunctionName() << " marked \"dontcall-";
+  DP << "call to " << demangle(getFunctionName().str())
+     << " marked \"dontcall-";
----------------
`demangle` returns a `std::string`. Is getting the C string necessary for printing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142844/new/

https://reviews.llvm.org/D142844



More information about the llvm-commits mailing list