[PATCH] D142900: [Thumb2] Upgrade intrinsic upgrading code

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D142900#4091015 <https://reviews.llvm.org/D142900#4091015>, @dmgreen wrote:

> Thanks for this.
>
> Do you know what happens with old IR and bitcode from a previous release? Will it see the old `@llvm.mve.vldr.gather.offset.predicated.v2i64.p0i64.v2i64.v4i1` names when auto-upgrading? Or will that have been converted to `@llvm.arm.mve.vstr.scatter.offset.predicated.p0.v2i64.v2i64.v4i1` by an earlier stage?

I //think// it will see the old `p0i64` name. That will get remangle-upgraded to the `p0` name, but after that the custom auto-upgrade won't be rerun.

So I think the right thing to do here would be to either just add both variants to the list, or modify the test to keep p0i64 in the original input. (I'd personally favor the former, as that should work no matter how the upgrade process works.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142900/new/

https://reviews.llvm.org/D142900