[PATCH] D139816: [LTO] Don't generate invalid modules if "LTOPostLink" MD already exists

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 03:31:52 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:632
   // Write LTOPostLink flag for passes that require all the modules.
-  MergedModule->addModuleFlag(Module::Error, "LTOPostLink", 1);
+  MergedModule->setModuleFlag(Module::Error, "LTOPostLink", 1);
 
----------------
Do you really need a new method? Can you just use ModFlagBehavior::Override?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139816/new/

https://reviews.llvm.org/D139816



More information about the llvm-commits mailing list