[PATCH] D142699: [AsmParser] Avoid instantiating LLVMContext if not needed. NFC

Mon Jan 30 01:42:28 PST 2023

yrouban added a comment.

In D142699#4085204 <https://reviews.llvm.org/D142699#4085204>, @arsenm wrote:

> Can you reupload the patch with full context?

Done

In D142699#4085204 <https://reviews.llvm.org/D142699#4085204>, @arsenm wrote:

> So this is recycling an existing, already used context? I keep running into bugs caused by doing that

Can you elaborate? What bugs do you see? I'm currently investigate a crash during deletion modules and functions from parsed modules, but my case does not use that local LLVMContext. So I just saw this extra instantiation and proposed to get rid of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142699/new/

https://reviews.llvm.org/D142699