[PATCH] D142705: [GVN] Support address translation through select instructions

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/PHITransAddr.cpp:347
+  Value *FalseAddr = PHITransAddr(*this).PHITranslateSubExpr(
+      Addr, CurBB, PredBB, DT, Sel, false);
+  return {TrueAddr, FalseAddr};
----------------
mkazantsev wrote:
> Why not
> ```
>   Value *TrueAddr = PHITransAddr(*this).PHITranslateSubExpr(Addr, CurBB, PredBB,
>                                                             DT, Sel->getTrueValue());
>   Value *FalseAddr = PHITransAddr(*this).PHITranslateSubExpr(
>       Addr, CurBB, PredBB, DT, Sel->getFalseValue());
> ```
> ?
Also, is `PHITransAddr(*this)` twice necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142705/new/

https://reviews.llvm.org/D142705