[PATCH] D140931: Improve and enable folding of conditional branches with tail calls.

Sun Jan 29 19:57:51 PST 2023

goldstein.w.n added inline comments.

================
Comment at: llvm/test/CodeGen/X86/switch-bt.ll:56-63
-; CHECK-LABEL: test2:
-; CHECK: cmpl $6
-; CHECK: ja

-; CHECK-NEXT: movl $91
-; CHECK-NOT: movl
-; CHECK-NEXT: btl
----------------
goldstein.w.n wrote:
> pengfei wrote:
> > Just noticed this. The manual written CHECK has gone, but no corresponding new check generated. Should we still use the old format with a bit twist?
> > Just noticed this. The manual written CHECK has gone, but no corresponding new check generated. Should we still use the old format with a bit twist?
> 
> We can also just remove the:
> `-asm-verbose=false` and then autogenerate. That Okay?
> Just noticed this. The manual written CHECK has gone, but no corresponding new check generated. Should we still use the old format with a bit twist?

Made D142860 to autogenerate tests for `switch-bt.ll`, then this one just updates.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140931/new/

https://reviews.llvm.org/D140931