[PATCH] D140931: Improve and enable folding of conditional branches with tail calls.

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 19:46:39 PST 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/switch-bt.ll:56-63
-; CHECK-LABEL: test2:
-; CHECK: cmpl $6
-; CHECK: ja
 
-; CHECK-NEXT: movl $91
-; CHECK-NOT: movl
-; CHECK-NEXT: btl
----------------
pengfei wrote:
> Just noticed this. The manual written CHECK has gone, but no corresponding new check generated. Should we still use the old format with a bit twist?
> Just noticed this. The manual written CHECK has gone, but no corresponding new check generated. Should we still use the old format with a bit twist?

We can also just remove the:
`-asm-verbose=false` and then autogenerate. That Okay?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140931/new/

https://reviews.llvm.org/D140931



More information about the llvm-commits mailing list