[PATCH] D142847: [InstCombine] reduce icmp_eq0-of-and-of-select-of-constants

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 12:32:43 PST 2023


spatel created this revision.
spatel added reviewers: RKSimon, goldstein.w.n, nikic, marcauberer.
Herald added subscribers: StephenFan, hiraditya, mcrosier.
Herald added a project: All.
spatel requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is the most basic patch to handle fixing issue #57666 <https://github.com/llvm/llvm-project/issues/57666>.

D133919 <https://reviews.llvm.org/D133919> proposes to handle much more than this in a single patch, but I've used 10 regression tests just to make sure this part is doing what I expected and nothing more, and it already shows even more potential TODO items.

The more general proofs from D133919 <https://reviews.llvm.org/D133919> are correct, but we should enable this in smaller steps to reduce risk:
https://alive2.llvm.org/ce/z/RrVEyX


https://reviews.llvm.org/D142847

Files:
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/test/Transforms/InstCombine/icmp-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142847.493128.patch
Type: text/x-patch
Size: 5344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230129/464ee33c/attachment.bin>


More information about the llvm-commits mailing list