[PATCH] D141893: [MC] Allow new .cfi_startproc in new section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

(back from a trip) Thanks!



================
Comment at: llvm/include/llvm/MC/MCStreamer.h:217
   std::vector<MCDwarfFrameInfo> DwarfFrameInfos;
+  SmallVector<std::pair<size_t, MCSection *>, 1> FrameInfoStack;
   MCDwarfFrameInfo *getCurrentDwarfFrameInfo();
----------------
This deserves a comment about what first/second are.


================
Comment at: llvm/test/MC/ELF/cfi-startproc-pushsection.s:1
+// RUN: llvm-mc -filetype=obj -triple x86_64-linux %s -o - | llvm-objdump --dwarf=frames - | FileCheck %s
+
----------------
`llvm-dwarfdump --eh-frame` is slightly preferred over `llvm-objdump`


================
Comment at: llvm/test/MC/ELF/cfi-startproc-pushsection.s:4
+.section .text.a, "ax", %progbits
+.cfi_startproc simple
+.cfi_def_cfa %rsp, 0
----------------
Change one `.cfi_startproc` to not use simple: to test more variants


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141893/new/

https://reviews.llvm.org/D141893